Skip to content

ADR on trino catalogs - #196

Merged
nightkr merged 12 commits into
mainfrom
adr-trino-catalogs
May 18, 2022
Merged

ADR on trino catalogs#196
nightkr merged 12 commits into
mainfrom
adr-trino-catalogs

Conversation

@sbernauer

@sbernauer sbernauer commented May 17, 2022

Copy link
Copy Markdown
Member

We still need a decision on both ADRs
Decison finished, can be presented in Arch meeting on Wednesday.

@sbernauer
sbernauer marked this pull request as draft May 17, 2022 08:40
@sbernauer

Copy link
Copy Markdown
Member Author

Adopted to decision in meeting today. Can be presented in Arch meeting on Wednesday.

@sbernauer
sbernauer marked this pull request as ready for review May 17, 2022 11:13
nightkr
nightkr previously approved these changes May 17, 2022
Comment thread modules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
Comment thread modules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
sbernauer and others added 2 commits May 17, 2022 14:06
….adoc

Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
….adoc

Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
@sbernauer

Copy link
Copy Markdown
Member Author

thx!
Could you please merge it when you have presented it tomorrow?

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some spelling.

Comment thread modules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
Comment thread modules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
Comment thread modules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
Comment thread modules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
Comment thread modules/contributor/pages/adr/ADR019-trino_catalog_definitions.adoc Outdated
Comment thread modules/contributor/pages/adr/ADR020-trino_catalog_usage.adoc Outdated
Comment thread modules/contributor/pages/adr/ADR020-trino_catalog_usage.adoc Outdated
sbernauer and others added 7 commits May 18, 2022 08:28
….adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
….adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
….adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
….adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
….adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@maltesander

Copy link
Copy Markdown
Member

We fine with merging this @teozkr @soenkeliebau ?

@nightkr

nightkr commented May 18, 2022

Copy link
Copy Markdown
Contributor

I suppose the remaining bit here would be the arch meeting presentation @maltesander.

@maltesander

Copy link
Copy Markdown
Member

I suppose the remaining bit here would be the arch meeting presentation @maltesander.

true ;)

@nightkr nightkr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@nightkr
nightkr merged commit 8bca58c into main May 18, 2022
@nightkr
nightkr deleted the adr-trino-catalogs branch May 18, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants